Make code for sqrt examples actually run#33
Open
O1O1O1O wants to merge 1 commit intoscala-exercises:mainfrom
Open
Make code for sqrt examples actually run#33O1O1O1O wants to merge 1 commit intoscala-exercises:mainfrom
O1O1O1O wants to merge 1 commit intoscala-exercises:mainfrom
Conversation
FRosner
approved these changes
Feb 1, 2018
julienrf
reviewed
Feb 1, 2018
| * | ||
| * def isGoodEnough(guess: Double, x: Double) = | ||
| * abs(square(guess) - x) < 0.001 | ||
| * math.abs(math.pow(guess, 2) - x) < 0.001 |
Collaborator
There was a problem hiding this comment.
I would use guess * guess instead of math.pow(guess, 2)
Author
|
Sorry, didn't realize you were going to approve as is. Amended with guess*guess and fixed another instance of the same problem. |
O1O1O1O
changed the title
julienrf
approved these changes
Feb 2, 2018
FRosner
approved these changes
Feb 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example code for
sqrtdidn't run when copy-pasted to a console.This change uses
math.absandmath.powinstead of justabsandsquareso it does.